Bug 143595

Summary: [CMake] Some internal variables are not marked as advanced
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKit Misc.Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, mcatanzaro, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
[CMake] Some internal variables are not marked as advanced none

Michael Catanzaro
Reported 2015-04-09 20:58:43 PDT
The FindFreetype2 module uses find_path and find_library without marking the result as advanced, like all the other find* modules do. Also, FindHarfBuzz was updated to look for harfbuzz-icu without marking HARFBUZZ_ICU_LIBRARIES as advanced.
Attachments
[CMake] Some internal variables are not marked as advanced (1.79 KB, patch)
2015-04-09 21:00 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-04-09 21:00:12 PDT
Created attachment 250499 [details] [CMake] Some internal variables are not marked as advanced
WebKit Commit Bot
Comment 2 2015-04-23 13:31:34 PDT
Comment on attachment 250499 [details] [CMake] Some internal variables are not marked as advanced Clearing flags on attachment: 250499 Committed r183206: <http://trac.webkit.org/changeset/183206>
WebKit Commit Bot
Comment 3 2015-04-23 13:31:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.