Bug 143593

Summary:

[Cocoa] Add a HAVE(AVKIT) and use it

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, eric.carlson, jer.noble

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ddkilzer: review+

Description Andy Estes 2015-04-09 18:28:07 PDT

[Cocoa] Add a HAVE(AVKIT) and use it

Comment 1 Andy Estes 2015-04-09 18:37:24 PDT

rdar://problem/20459274

Comment 2 Andy Estes 2015-04-09 18:40:04 PDT

Created attachment 250494 [details]
Patch

Comment 3 David Kilzer (:ddkilzer) 2015-04-09 21:23:01 PDT

Comment on attachment 250494 [details]
Patch

r=me

In the long term, we may not want to assume PLATFORM(IOS) is always defined when PLATFORM(WATCHOS) is defined, but this seems fine for now.

Comment 4 Andy Estes 2015-04-09 22:16:59 PDT

(In reply to comment #3)
> Comment on attachment 250494 [details]
> Patch
> 
> r=me

Thanks!

> In the long term, we may not want to assume PLATFORM(IOS) is always defined
> when PLATFORM(WATCHOS) is defined, but this seems fine for now.

Yeah, I guess having PLATFORM(IOS) be true on Watch OS is a little like the old days of PLATFORM(MAC) being true on iOS. Ultimately we'd want a macro that represents all iOS-derived platforms, and another one that represents just iOS. Right now though, having PLATFORM(IOS) be true on Watch OS is a useful starting point.

Comment 5 Andy Estes 2015-04-10 01:34:38 PDT

Committed r182623: <http://trac.webkit.org/changeset/182623>