Wireless player placard for OSX

• Component: Media
• Status: RESOLVED FIXED

[Roger Fong]

This covers both big and small versions.

rdar://problem/12067439

[Roger Fong]

Created attachment 250485 [details]
patch

[Eric Carlson]

Comment on attachment 250485 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250485&action=review

r=me with the minor changes noted.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:463
> +        inlinePlaybackPlaceholderTextTop.innerText = 'AirPlay';

This string should go into mediaControlsLocalizedStrings.js

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:467
> +        inlinePlaybackPlaceholderTextBottom.innerText = 'This video is playing on "AppleTV"'

Ditto.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1757
> +        console.log(deviceName);

Please remove this.

[Roger Fong]

(In reply to comment #2)
> Comment on attachment 250485 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250485&action=review
> 
> r=me with the minor changes noted.
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:463
> > +        inlinePlaybackPlaceholderTextTop.innerText = 'AirPlay';
> 
> This string should go into mediaControlsLocalizedStrings.js
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:467
> > +        inlinePlaybackPlaceholderTextBottom.innerText = 'This video is playing on "AppleTV"'
> 
> Ditto.

Actually I'll just get rid of those two altogether.
We always run the updateWirelessPlaybackStatus method on initialization which initializes those values with the appropriate strings anyways.

> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1757
> > +        console.log(deviceName);
> 
> Please remove this.

[Roger Fong]

http://trac.webkit.org/changeset/182631

[Roger Fong]

(In reply to comment #4)
> http://trac.webkit.org/changeset/182631

http://trac.webkit.org/changeset/182771