Bug 143585 - Wireless player placard for OSX
Summary: Wireless player placard for OSX
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-09 15:44 PDT by Roger Fong
Modified: 2015-04-13 17:14 PDT (History)
0 users

See Also:

Attachments
patch (14.11 KB, patch)
2015-04-09 16:19 PDT, Roger Fong 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-04-09 15:44:05 PDT 
This covers both big and small versions.

rdar://problem/12067439
Comment 1 Roger Fong 2015-04-09 16:19:15 PDT 
Created attachment 250485 [details]
patch
Comment 2 Eric Carlson 2015-04-10 07:14:10 PDT 
Comment on attachment 250485 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250485&action=review

r=me with the minor changes noted.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:463
> +        inlinePlaybackPlaceholderTextTop.innerText = 'AirPlay';

This string should go into mediaControlsLocalizedStrings.js

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:467
> +        inlinePlaybackPlaceholderTextBottom.innerText = 'This video is playing on "AppleTV"'

Ditto.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1757
> +        console.log(deviceName);

Please remove this.
Comment 3 Roger Fong 2015-04-10 10:19:39 PDT 
(In reply to comment #2)
> Comment on attachment 250485 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250485&action=review
> 
> r=me with the minor changes noted.
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:463
> > +        inlinePlaybackPlaceholderTextTop.innerText = 'AirPlay';
> 
> This string should go into mediaControlsLocalizedStrings.js
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:467
> > +        inlinePlaybackPlaceholderTextBottom.innerText = 'This video is playing on "AppleTV"'
> 
> Ditto.

Actually I'll just get rid of those two altogether.
We always run the updateWirelessPlaybackStatus method on initialization which initializes those values with the appropriate strings anyways.

> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1757
> > +        console.log(deviceName);
> 
> Please remove this.
Comment 4 Roger Fong 2015-04-10 10:34:49 PDT 
http://trac.webkit.org/changeset/182631