Bug 143584

Summary: [CMake] Remove unnecessary ENABLE_WEBCORE switch
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2015-04-09 15:37:05 PDT
WebCore should be built for all ports. So ENABLE_WEBCORE switch looks be redundant.
Attachments
Patch (3.24 KB, patch)
2015-04-09 15:38 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (3.69 KB, patch)
2015-04-10 00:21 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-04-09 15:38:00 PDT
Created attachment 250474 [details] Patch
Ryuan Choi
Comment 2 2015-04-09 17:01:46 PDT
(In reply to comment #0) > WebCore should be built for all ports. So ENABLE_WEBCORE switch looks be > redundant. I am not sure but if I am right, it is to build jsc only. Someone may want to build only jsc to use stand-alone javascript engine without webcore. It can be usefull for javascript engine developers.
Gyuyoung Kim
Comment 3 2015-04-09 19:32:18 PDT
(In reply to comment #2) > (In reply to comment #0) > > WebCore should be built for all ports. So ENABLE_WEBCORE switch looks be > > redundant. > > I am not sure but if I am right, it is to build jsc only. > > Someone may want to build only jsc to use stand-alone javascript engine > without webcore. > It can be usefull for javascript engine developers. However I don't know who uses this option only to build jsc. Probably Ossy may use it. However Ossy doesn't use it. It looks nobody use it. Ossy, do you think ENABLE_WEBCORE is still needed for us ?
Csaba Osztrogonác
Comment 4 2015-04-09 23:45:01 PDT
Comment on attachment 250474 [details] Patch I use Tools/Scripts/build-jsc to build only JSC, which generates the complete makefile/ninja.build and then call it to build only jsc target. build-jsc is happy with this change, so I can't see a reason to keep this condition. Additionally you can remove "set(ENABLE_WEBCORE ON)" from CMakeLists.txt:27 too.
Csaba Osztrogonác
Comment 5 2015-04-09 23:53:46 PDT
For historical note http://trac.webkit.org/changeset/103417 introduced this option to be able build only jsc, http://trac.webkit.org/changeset/103464 added the build-jsc change and after http://trac.webkit.org/changeset/114508 this option became unused.
Ryuan Choi
Comment 6 2015-04-10 00:05:07 PDT
(In reply to comment #5) > For historical note http://trac.webkit.org/changeset/103417 introduced > this option to be able build only jsc, > http://trac.webkit.org/changeset/103464 > added the build-jsc change and after http://trac.webkit.org/changeset/114508 > this option became unused. Thanks for the clarifying.
Gyuyoung Kim
Comment 7 2015-04-10 00:21:24 PDT
Created attachment 250502 [details] Patch
Gyuyoung Kim
Comment 8 2015-04-10 00:50:30 PDT
Comment on attachment 250502 [details] Patch Thank you Ossy and Ryuan.
WebKit Commit Bot
Comment 9 2015-04-10 01:37:47 PDT
Comment on attachment 250502 [details] Patch Clearing flags on attachment: 250502 Committed r182624: <http://trac.webkit.org/changeset/182624>
WebKit Commit Bot
Comment 10 2015-04-10 01:37:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.