Bug 143485

Summary: ContextMenuItem refactoring
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Severity: Normal CC: bdakin, bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Remove a default parameter
Try again to get win EWS to look at this.
Patch v1 none

Description Brady Eidson 2015-04-07 10:29:36 PDT
ContextMenuItem refactoring to support "null item"

This will be a useful concept to have in ContextMenu refactoring and new features that use ContextMenu(Item)
Comment 1 Brady Eidson 2015-04-07 10:31:37 PDT
Created attachment 250272 [details]
Remove a default parameter

Removing this default parameter in a ContextMenuItem constructor will determine whether I can immediately introduce a "ContextMenuItem()" constructor for the null item.

EWS will give me the answer!
Comment 2 Brady Eidson 2015-04-07 12:32:01 PDT
Created attachment 250283 [details]
Try again to get win EWS to look at this.

Actually am concerned about Windows, need it ran by EWS.
Comment 3 Brady Eidson 2015-04-07 13:25:47 PDT
Great, that works.

So I'll be adding here:
1 - An empty constructor and the concept of a "null menu item"
2 - Removing "releasePlatformDescription" from Mac (GTK still needs it)
3 - Renaming "getPlatformDescription"
Comment 4 Brady Eidson 2015-04-07 13:38:47 PDT
Created attachment 250293 [details]
Patch v1
Comment 5 WebKit Commit Bot 2015-04-07 14:30:08 PDT
Comment on attachment 250293 [details]
Patch v1

Clearing flags on attachment: 250293

Committed r182494: <http://trac.webkit.org/changeset/182494>
Comment 6 WebKit Commit Bot 2015-04-07 14:30:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Brent Fulgham 2015-04-07 15:14:12 PDT
This broke the Windows build:

..\platform\win\ContextMenuItemWin.cpp(34): error C2511: 'WebCore::ContextMenuItem::ContextMenuItem(void)' : overloaded member function not found in 'WebCore::ContextMenuItem' [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj]
          C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\ContextMenuItem.h(187) : see declaration of 'WebCore::ContextMenuItem'