Summary: | ContextMenuItem refactoring | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bdakin, bfulgham, commit-queue | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Brady Eidson
2015-04-07 10:29:36 PDT
Created attachment 250272 [details]
Remove a default parameter
Removing this default parameter in a ContextMenuItem constructor will determine whether I can immediately introduce a "ContextMenuItem()" constructor for the null item.
EWS will give me the answer!
Created attachment 250283 [details]
Try again to get win EWS to look at this.
Actually am concerned about Windows, need it ran by EWS.
Great, that works. So I'll be adding here: 1 - An empty constructor and the concept of a "null menu item" 2 - Removing "releasePlatformDescription" from Mac (GTK still needs it) 3 - Renaming "getPlatformDescription" Created attachment 250293 [details]
Patch v1
Comment on attachment 250293 [details] Patch v1 Clearing flags on attachment: 250293 Committed r182494: <http://trac.webkit.org/changeset/182494> All reviewed patches have been landed. Closing bug. This broke the Windows build: ..\platform\win\ContextMenuItemWin.cpp(34): error C2511: 'WebCore::ContextMenuItem::ContextMenuItem(void)' : overloaded member function not found in 'WebCore::ContextMenuItem' [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\ContextMenuItem.h(187) : see declaration of 'WebCore::ContextMenuItem' |