Bug 143485

Summary:

ContextMenuItem refactoring

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, bfulgham, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Remove a default parameter	none
Try again to get win EWS to look at this.	none
Patch v1	none

Brady Eidson

Reported 2015-04-07 10:29:36 PDT

ContextMenuItem refactoring to support "null item" This will be a useful concept to have in ContextMenu refactoring and new features that use ContextMenu(Item)

Attachments
Remove a default parameter (693 bytes, patch) 2015-04-07 10:31 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Try again to get win EWS to look at this. (693 bytes, patch) 2015-04-07 12:32 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v1 (8.95 KB, patch) 2015-04-07 13:38 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2015-04-07 10:31:37 PDT

Created attachment 250272 [details] Remove a default parameter Removing this default parameter in a ContextMenuItem constructor will determine whether I can immediately introduce a "ContextMenuItem()" constructor for the null item. EWS will give me the answer!

Brady Eidson

Comment 2 2015-04-07 12:32:01 PDT

Created attachment 250283 [details] Try again to get win EWS to look at this. Actually am concerned about Windows, need it ran by EWS.

Brady Eidson

Comment 3 2015-04-07 13:25:47 PDT

Great, that works. So I'll be adding here: 1 - An empty constructor and the concept of a "null menu item" 2 - Removing "releasePlatformDescription" from Mac (GTK still needs it) 3 - Renaming "getPlatformDescription"

Brady Eidson

Comment 4 2015-04-07 13:38:47 PDT

Created attachment 250293 [details] Patch v1

WebKit Commit Bot

Comment 5 2015-04-07 14:30:08 PDT

Comment on attachment 250293 [details] Patch v1 Clearing flags on attachment: 250293 Committed r182494: <http://trac.webkit.org/changeset/182494>

WebKit Commit Bot

Comment 6 2015-04-07 14:30:12 PDT

All reviewed patches have been landed. Closing bug.

Brent Fulgham

Comment 7 2015-04-07 15:14:12 PDT

This broke the Windows build: ..\platform\win\ContextMenuItemWin.cpp(34): error C2511: 'WebCore::ContextMenuItem::ContextMenuItem(void)' : overloaded member function not found in 'WebCore::ContextMenuItem' [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\ContextMenuItem.h(187) : see declaration of 'WebCore::ContextMenuItem'

Note You need to log in before you can comment on or make changes to this bug.