Bug 143470

Summary:

[Content Filtering] Add logging

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, japhet

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

128858

Attachments:

Description	Flags
Patch	dbates: review+

Description Andy Estes 2015-04-07 02:16:31 PDT

[Content Filtering] Add logging

Comment 1 Andy Estes 2015-04-07 02:18:01 PDT

Created attachment 250261 [details]
Patch

Comment 2 Daniel Bates 2015-04-07 13:39:21 PDT

Comment on attachment 250261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250261&action=review

> Source/WebCore/testing/MockContentFilter.cpp:136
> +    LOG(ContentFiltering, "MockContentFilter stopped buffering with status %du at decision point %du.\n", m_status, decisionPoint);

Is %du a valid format specifier?

Comment 3 Andy Estes 2015-04-07 13:41:35 PDT

(In reply to comment #2)
> Comment on attachment 250261 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250261&action=review
> 
> > Source/WebCore/testing/MockContentFilter.cpp:136
> > +    LOG(ContentFiltering, "MockContentFilter stopped buffering with status %du at decision point %du.\n", m_status, decisionPoint);
> 
> Is %du a valid format specifier?

Eh, I probably just want %u.

Comment 4 Andy Estes 2015-04-07 13:49:28 PDT

Committed r182489: <http://trac.webkit.org/changeset/182489>