Bug 143439

Summary: Use a RenderObject bit for isRenderFlowThread()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Simon Fraser (smfr) 2015-04-05 21:52:20 PDT 
Use a RenderObject bit for isRenderFlowThread()
Comment 1 Simon Fraser (smfr) 2015-04-05 21:54:16 PDT 
Created attachment 250192 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-04-05 22:07:08 PDT 
Comment on attachment 250192 [details]
Patch

Actually I'm going to put this in rare data.
Comment 3 Simon Fraser (smfr) 2015-04-05 22:33:49 PDT 
Created attachment 250194 [details]
Patch
Comment 4 zalan 2015-04-06 07:28:00 PDT 
What's the long term plan here? Are we turning RenderObject::isRender####() functions into bitfields/rare data? (and what makes it rare data?)
Comment 5 Simon Fraser (smfr) 2015-04-06 09:15:35 PDT 
Comment on attachment 250194 [details]
Patch

We've always had a policy of converting virtual function calls into bit checks on an ad-hoc basis as a result of performance analysis.
Comment 6 WebKit Commit Bot 2015-04-06 10:01:49 PDT 
Comment on attachment 250194 [details]
Patch

Clearing flags on attachment: 250194

Committed r182431: <http://trac.webkit.org/changeset/182431>
Comment 7 WebKit Commit Bot 2015-04-06 10:01:57 PDT 
All reviewed patches have been landed.  Closing bug.