Bug 143439

Summary: Use a RenderObject bit for isRenderFlowThread()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2015-04-05 21:52:20 PDT
Use a RenderObject bit for isRenderFlowThread()
Attachments
Patch (5.09 KB, patch)
2015-04-05 21:54 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (5.72 KB, patch)
2015-04-05 22:33 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-04-05 21:54:16 PDT
Created attachment 250192 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-04-05 22:07:08 PDT
Comment on attachment 250192 [details] Patch Actually I'm going to put this in rare data.
Simon Fraser (smfr)
Comment 3 2015-04-05 22:33:49 PDT
Created attachment 250194 [details] Patch
zalan
Comment 4 2015-04-06 07:28:00 PDT
What's the long term plan here? Are we turning RenderObject::isRender####() functions into bitfields/rare data? (and what makes it rare data?)
Simon Fraser (smfr)
Comment 5 2015-04-06 09:15:35 PDT
Comment on attachment 250194 [details] Patch We've always had a policy of converting virtual function calls into bit checks on an ad-hoc basis as a result of performance analysis.
WebKit Commit Bot
Comment 6 2015-04-06 10:01:49 PDT
Comment on attachment 250194 [details] Patch Clearing flags on attachment: 250194 Committed r182431: <http://trac.webkit.org/changeset/182431>
WebKit Commit Bot
Comment 7 2015-04-06 10:01:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.