Bug 143439 - Use a RenderObject bit for isRenderFlowThread()
Summary: Use a RenderObject bit for isRenderFlowThread()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-05 21:52 PDT by Simon Fraser (smfr)
Modified: 2015-04-06 10:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.09 KB, patch)
2015-04-05 21:54 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (5.72 KB, patch)
2015-04-05 22:33 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-04-05 21:52:20 PDT 
Use a RenderObject bit for isRenderFlowThread()
Comment 1 Simon Fraser (smfr) 2015-04-05 21:54:16 PDT 
Created attachment 250192 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-04-05 22:07:08 PDT 
Comment on attachment 250192 [details]
Patch

Actually I'm going to put this in rare data.
Comment 3 Simon Fraser (smfr) 2015-04-05 22:33:49 PDT 
Created attachment 250194 [details]
Patch
Comment 4 zalan 2015-04-06 07:28:00 PDT 
What's the long term plan here? Are we turning RenderObject::isRender####() functions into bitfields/rare data? (and what makes it rare data?)
Comment 5 Simon Fraser (smfr) 2015-04-06 09:15:35 PDT 
Comment on attachment 250194 [details]
Patch

We've always had a policy of converting virtual function calls into bit checks on an ad-hoc basis as a result of performance analysis.
Comment 6 WebKit Commit Bot 2015-04-06 10:01:49 PDT 
Comment on attachment 250194 [details]
Patch

Clearing flags on attachment: 250194

Committed r182431: <http://trac.webkit.org/changeset/182431>
Comment 7 WebKit Commit Bot 2015-04-06 10:01:57 PDT 
All reviewed patches have been landed.  Closing bug.