Bug 143435

Summary: [Content Filtering] Add some additional unblock tests
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, kling, mitz, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128858    
Attachments:
Description Flags
Patch mitz: review+

Andy Estes
Reported 2015-04-05 20:27:40 PDT
[Content Filtering] Add some additional unblock tests
Attachments
Patch (14.99 KB, patch)
2015-04-05 20:28 PDT, Andy Estes 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2015-04-05 20:28:58 PDT
Created attachment 250189 [details] Patch
mitz
Comment 2 2015-04-05 21:40:11 PDT
Comment on attachment 250189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250189&action=review > LayoutTests/contentfiltering/block-after-will-send-request-then-deny-unblock.html:6 > + testContentFiltering(/* decisionPoint */settings.DECISION_POINT_AFTER_WILL_SEND_REQUEST, /* decision */settings.DECISION_ALLOW, /* decideAfterUnblockRequest */true); Shouldn’t the decision here be DECISION_BLOCK?
Andy Estes
Comment 3 2015-04-05 21:43:20 PDT
(In reply to comment #2) > Comment on attachment 250189 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250189&action=review > > > LayoutTests/contentfiltering/block-after-will-send-request-then-deny-unblock.html:6 > > + testContentFiltering(/* decisionPoint */settings.DECISION_POINT_AFTER_WILL_SEND_REQUEST, /* decision */settings.DECISION_ALLOW, /* decideAfterUnblockRequest */true); > > Shouldn’t the decision here be DECISION_BLOCK? Yes, it should be DECISION_BLOCK. Thank you for catching that!
mitz
Comment 4 2015-04-05 21:45:21 PDT
Comment on attachment 250189 [details] Patch r=me with that fixed :)
Andy Estes
Comment 5 2015-04-05 21:49:37 PDT
Committed r182376: <http://trac.webkit.org/changeset/182376>
Note You need to log in before you can comment on or make changes to this bug.