Bug 143435

Summary: [Content Filtering] Add some additional unblock tests
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, kling, mitz, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128858    
Attachments:
Description Flags
Patch mitz: review+

Description Andy Estes 2015-04-05 20:27:40 PDT
[Content Filtering] Add some additional unblock tests
Comment 1 Andy Estes 2015-04-05 20:28:58 PDT
Created attachment 250189 [details]
Patch
Comment 2 mitz 2015-04-05 21:40:11 PDT
Comment on attachment 250189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250189&action=review

> LayoutTests/contentfiltering/block-after-will-send-request-then-deny-unblock.html:6
> +    testContentFiltering(/* decisionPoint */settings.DECISION_POINT_AFTER_WILL_SEND_REQUEST, /* decision */settings.DECISION_ALLOW, /* decideAfterUnblockRequest */true);

Shouldn’t the decision here be DECISION_BLOCK?
Comment 3 Andy Estes 2015-04-05 21:43:20 PDT
(In reply to comment #2)
> Comment on attachment 250189 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250189&action=review
> 
> > LayoutTests/contentfiltering/block-after-will-send-request-then-deny-unblock.html:6
> > +    testContentFiltering(/* decisionPoint */settings.DECISION_POINT_AFTER_WILL_SEND_REQUEST, /* decision */settings.DECISION_ALLOW, /* decideAfterUnblockRequest */true);
> 
> Shouldn’t the decision here be DECISION_BLOCK?

Yes, it should be DECISION_BLOCK. Thank you for catching that!
Comment 4 mitz 2015-04-05 21:45:21 PDT
Comment on attachment 250189 [details]
Patch

r=me with that fixed :)
Comment 5 Andy Estes 2015-04-05 21:49:37 PDT
Committed r182376: <http://trac.webkit.org/changeset/182376>