Bug 143434

Summary: Web Inspector: Add String/Array "includes" parameter display string
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-04-05 18:33:38 PDT
* SUMMARY Add String/Array "includes" parameter display string. * TEST 1. js> dir([]) 2. Expand prototype => "includes" looks like it takes no parameters * EXPECTED "includes(searchElement, [startIndex=0])" like "indexOf"
Attachments
[PATCH] Proposed Fix (2.03 KB, patch)
2015-04-05 18:36 PDT, Joseph Pecoraro
no flags
Radar WebKit Bug Importer
Comment 1 2015-04-05 18:33:54 PDT
Joseph Pecoraro
Comment 2 2015-04-05 18:36:51 PDT
Created attachment 250185 [details] [PATCH] Proposed Fix
Darin Adler
Comment 3 2015-04-05 20:13:54 PDT
Comment on attachment 250185 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=250185&action=review > Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js:37 > + getOwnPropertySymbols: "object", Not mentioned in change log.
WebKit Commit Bot
Comment 4 2015-04-05 21:02:36 PDT
Comment on attachment 250185 [details] [PATCH] Proposed Fix Clearing flags on attachment: 250185 Committed r182375: <http://trac.webkit.org/changeset/182375>
WebKit Commit Bot
Comment 5 2015-04-05 21:02:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.