Bug 143430

Summary: Use jsNontrivialString in more places if the string is guaranteed to be 2 or more characters
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, ggaren, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix darin: review+

Description Joseph Pecoraro 2015-04-05 17:40:01 PDT 
* SUMMARY
Use jsNontrivialString in more places if the string is guaranteed to be 2 or more characters.

* NOTES
- "NaN", "Infinity", and large values with "e" are guaranteed to have 2 or more characters
- Symbol's description string is guaranteed to at least have "Symbol()"
- A quoted string is guaranteed to have at least the two quotes
Comment 1 Joseph Pecoraro 2015-04-05 17:40:54 PDT 
Created attachment 250180 [details]
[PATCH] Proposed Fix
Comment 2 Darin Adler 2015-04-05 20:05:05 PDT 
Comment on attachment 250180 [details]
[PATCH] Proposed Fix

Symbol::descriptiveString should use makeString instead of StringBuilder.
Comment 3 Joseph Pecoraro 2015-04-08 18:39:11 PDT 
http://trac.webkit.org/changeset/182577
Comment 4 Joseph Pecoraro 2015-04-08 18:39:27 PDT 
(In reply to comment #2)
> Comment on attachment 250180 [details]
> [PATCH] Proposed Fix
> 
> Symbol::descriptiveString should use makeString instead of StringBuilder.

Will do this separately.