Bug 143421

Summary: Remove "go ahead and" from comments
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, hyatt, mitz, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+, benjamin: commit-queue-

Simon Fraser (smfr)
Reported 2015-04-05 12:54:13 PDT
Remove "go ahead and" from comments
Attachments
Patch (62.65 KB, patch)
2015-04-05 12:57 PDT, Simon Fraser (smfr) 		darin: review+
benjamin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-04-05 12:57:00 PDT
Created attachment 250161 [details] Patch
Darin Adler
Comment 2 2015-04-05 13:09:48 PDT
Comment on attachment 250161 [details] Patch Commit queue: go ahead and land this patch.
Benjamin Poulain
Comment 3 2015-04-05 13:13:22 PDT
Comment on attachment 250161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250161&action=review > Source/WebCore/loader/DocumentLoader.cpp:909 > + // frame have any loads active, so and kill all the loads. so and kill? > Source/WebCore/platform/ScrollView.cpp:607 > + // If we came in here with the view already needing a layout, then do that first. I the comma useful here? > Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1637 > - return ObjectContentFrame; // Go ahead and hope that we can display the content. > + return ObjectContentFrame; // Just hope that we can display the content. Not convinced this one is an improvement.
Simon Fraser (smfr)
Comment 4 2015-04-05 13:18:52 PDT
https://trac.webkit.org/r182364
Note You need to log in before you can comment on or make changes to this bug.