| Summary: | Remove "go ahead and" from comments | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, commit-queue, hyatt, mitz, sam, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2015-04-05 12:54:13 PDT
Created attachment 250161 [details]
Patch
Comment on attachment 250161 [details]
Patch
Commit queue: go ahead and land this patch.
Comment on attachment 250161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250161&action=review > Source/WebCore/loader/DocumentLoader.cpp:909 > + // frame have any loads active, so and kill all the loads. so and kill? > Source/WebCore/platform/ScrollView.cpp:607 > + // If we came in here with the view already needing a layout, then do that first. I the comma useful here? > Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1637 > - return ObjectContentFrame; // Go ahead and hope that we can display the content. > + return ObjectContentFrame; // Just hope that we can display the content. Not convinced this one is an improvement. |