Bug 143400

Summary: Network cache Bloom filter is too big
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
cdumez: review+
with a thread safety fix none

Antti Koivisto
Reported 2015-04-04 08:20:54 PDT
Switch from a counting filter to to a bit filter.
Attachments
patch (14.29 KB, patch)
2015-04-04 08:56 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (14.94 KB, patch)
2015-04-04 11:57 PDT, Antti Koivisto 		cdumez: review+
DetailsFormatted DiffDiff
with a thread safety fix (14.99 KB, patch)
2015-04-05 02:56 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-04-04 08:21:26 PDT
<rdar://problem/20426756>
Antti Koivisto
Comment 2 2015-04-04 08:56:37 PDT
Created attachment 250127 [details] patch
Antti Koivisto
Comment 3 2015-04-04 11:57:34 PDT
Created attachment 250133 [details] patch
Chris Dumez
Comment 4 2015-04-04 17:05:39 PDT
Comment on attachment 250133 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=250133&action=review Nice, r=me. > Source/WebKit2/ChangeLog:51 > +2015-04-03 Antti Koivisto <antti@apple.com> Extra ChangeLog. > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:523 > + // This was added already when starting the store but filter might have got wiped. s/got/been/
Antti Koivisto
Comment 5 2015-04-05 02:56:53 PDT
Created attachment 250154 [details] with a thread safety fix
Antti Koivisto
Comment 6 2015-04-05 08:23:25 PDT
https://trac.webkit.org/r182357
Note You need to log in before you can comment on or make changes to this bug.