Bug 143400

Summary:

Network cache Bloom filter is too big

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	cdumez: review+
with a thread safety fix	none

Description Antti Koivisto 2015-04-04 08:20:54 PDT

Switch from a counting filter to to a bit filter.

Comment 1 Radar WebKit Bug Importer 2015-04-04 08:21:26 PDT

<rdar://problem/20426756>

Comment 2 Antti Koivisto 2015-04-04 08:56:37 PDT

Created attachment 250127 [details]
patch

Comment 3 Antti Koivisto 2015-04-04 11:57:34 PDT

Created attachment 250133 [details]
patch

Comment 4 Chris Dumez 2015-04-04 17:05:39 PDT

Comment on attachment 250133 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250133&action=review

Nice, r=me.

> Source/WebKit2/ChangeLog:51
> +2015-04-03  Antti Koivisto  <antti@apple.com>

Extra ChangeLog.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:523
> +    // This was added already when starting the store but filter might have got wiped.

s/got/been/

Comment 5 Antti Koivisto 2015-04-05 02:56:53 PDT

Created attachment 250154 [details]
with a thread safety fix

Comment 6 Antti Koivisto 2015-04-05 08:23:25 PDT

https://trac.webkit.org/r182357