Bug 143361

Summary:

Fix the EFL and GTK build after r182243

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

achristensen, commit-queue, fpizlo, ossy, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2015-04-02 23:16:51 PDT

See https://bugs.webkit.org/show_bug.cgi?id=143293#c12 for details.
The clean build is still broken. :(

Comment 1 Zan Dobersek 2015-04-03 02:59:19 PDT

I'll produce something.

Comment 2 Zan Dobersek 2015-04-03 04:25:19 PDT

Created attachment 250058 [details]
Patch

Comment 3 WebKit Commit Bot 2015-04-03 04:27:53 PDT

Attachment 250058 [details] did not pass style-queue:


ERROR: Source/WebKit2/PlatformGTK.cmake:425:  There should be exactly one empty line instead of 0 between ""        <file alias=\"images/panIcon\">panIcon.png</file>\n"" and ""        <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n"".  [list/emptyline] [5]
ERROR: Source/WebKit2/PlatformGTK.cmake:426:  Alphabetical sorting problem. ""        <file alias=\"images/textAreaResizeCorner@2x\">textAreaResizeCorner@2x.png</file>\n"" should be before ""        <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n"".  [list/order] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Zan Dobersek 2015-04-03 04:33:10 PDT

(In reply to comment #2)
> Created attachment 250058 [details]
> Patch

Fixes clean builds for the GTK port. EFL fix is speculative, so please test it out.

Comment 5 Csaba Osztrogonác 2015-04-03 04:34:31 PDT

(In reply to comment #4)
> (In reply to comment #2)
> > Created attachment 250058 [details]
> > Patch
> 
> Fixes clean builds for the GTK port. EFL fix is speculative, so please test
> it out.

Thanks for the fix, I'll check it immediately.

Comment 6 Csaba Osztrogonác 2015-04-03 04:45:24 PDT

Comment on attachment 250058 [details]
Patch

It works on EFL too, so r=me.

Comment 7 Zan Dobersek 2015-04-03 05:23:55 PDT

Comment on attachment 250058 [details]
Patch

Clearing flags on attachment: 250058

Committed r182315: <http://trac.webkit.org/changeset/182315>

Comment 8 Zan Dobersek 2015-04-03 05:24:05 PDT

All reviewed patches have been landed.  Closing bug.

Comment 9 Gyuyoung Kim 2015-04-03 05:43:50 PDT

Comment on attachment 250058 [details]
Patch

Thank you for the fix !