| Summary: | Some elements missing from fullscreen media controls | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||||||
| Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED INVALID | ||||||||||
| Severity: | Normal | CC: | buildbot, dino, eric.carlson, rniwa, roger_fong | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Roger Fong
2015-04-02 17:04:16 PDT
Created attachment 250022 [details]
patch
Note: hasVisualMedia was only used for the purpose of determining whether or not the fullscreen button is hidden... Comment on attachment 250022 [details] patch Attachment 250022 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4922848489504768 New failing tests: media/audio-as-video-fullscreen.html Created attachment 250024 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
(In reply to comment #3) > Note: hasVisualMedia was only used for the purpose of determining whether or > not the fullscreen button is hidden... Oh I see, the purpose of hasVisualMedia was to distinguish with the audio controls, not as a way of determining whether or not content had been loaded. Will fix. Comment on attachment 250022 [details] patch Attachment 250022 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5473272170807296 New failing tests: media/audio-as-video-fullscreen.html Created attachment 250027 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
On second thought why do we even support an audio format in a video element? That's not in the W3C spec and should generate an error. (In reply to comment #9) > On second thought why do we even support an audio format in a video element? > That's not in the W3C spec and should generate an error. It is perfectly legal to have an audio-only file in a <video> element, or a file with audio and video (and text) in an <audio> element. No longer valid. Comment on attachment 250022 [details] patch Cleared review? from attachment 250022 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). |