Summary: | Add Options::dumpSourceAtDFGTime() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, fpizlo, ggaren, mmirman, msaboff | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2015-04-02 15:27:16 PDT
(In reply to comment #0) > Sometimes, we will want to see the JSC source code ... typo: ... want to see the JS source code ... Created attachment 250014 [details]
the patch.
Comment on attachment 250014 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=250014&action=review r=me > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:3988 > + dataLog("==== begin source ====\n"); Do we this this delimiter? > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:3990 > + dataLog("\n==== end source ====\n\n"); ditto (In reply to comment #3) > Comment on attachment 250014 [details] > the patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250014&action=review > > r=me > > > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:3988 > > + dataLog("==== begin source ====\n"); > > Do we this this delimiter? > > > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:3990 > > + dataLog("\n==== end source ====\n\n"); > > ditto It helps. Consider the case where we actually compile eval or global code which don't have a { } around them. Plus this is only debugging code. So, let's go with these for now. Thanks for the review. Landed in r182294: <http://trac.webkit.org/r182294>. |