Bug 143294

Summary:

css3/flexbox/csswg/css-flexbox-height-animation-stretch.html is flaky

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	dino: review+, commit-queue: commit-queue-

Description Alexey Proskuryakov 2015-03-31 23:29:29 PDT

css3/flexbox/csswg/css-flexbox-height-animation-stretch.html is flaky:

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=css3%2Fflexbox%2Fcsswg%2Fcss-flexbox-height-animation-stretch.html

It just looks like the kind of test that's interactive only, as there should be no red appearing at any time during animation. So, we don't actually test much via run-webkit-test, but also we have a timing dependent flakiness.

Comment 1 Alexey Proskuryakov 2015-03-31 23:31:57 PDT

Created attachment 249897 [details]
proposed patch

Comment 2 Alexey Proskuryakov 2015-04-01 18:53:05 PDT

Dean, does this look right to you?

Comment 3 WebKit Commit Bot 2015-04-02 15:46:43 PDT

Comment on attachment 249897 [details]
proposed patch

Rejecting attachment 249897 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 249897, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/4946734950121472

Comment 4 Alexey Proskuryakov 2015-09-04 09:21:44 PDT

Landed in r189346.