Bug 143294 - css3/flexbox/csswg/css-flexbox-height-animation-stretch.html is flaky
Summary: css3/flexbox/csswg/css-flexbox-height-animation-stretch.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-31 23:29 PDT by Alexey Proskuryakov
Modified: 2015-09-04 09:21 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (1.29 KB, patch)
2015-03-31 23:31 PDT, Alexey Proskuryakov
dino: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-03-31 23:29:29 PDT
css3/flexbox/csswg/css-flexbox-height-animation-stretch.html is flaky:

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=css3%2Fflexbox%2Fcsswg%2Fcss-flexbox-height-animation-stretch.html

It just looks like the kind of test that's interactive only, as there should be no red appearing at any time during animation. So, we don't actually test much via run-webkit-test, but also we have a timing dependent flakiness.
Comment 1 Alexey Proskuryakov 2015-03-31 23:31:57 PDT
Created attachment 249897 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2015-04-01 18:53:05 PDT
Dean, does this look right to you?
Comment 3 WebKit Commit Bot 2015-04-02 15:46:43 PDT
Comment on attachment 249897 [details]
proposed patch

Rejecting attachment 249897 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 249897, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/4946734950121472
Comment 4 Alexey Proskuryakov 2015-09-04 09:21:44 PDT
Landed in r189346.