| Summary: | Support forcing expansion opportunities at the beginning and ending of a run | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dino, esprehn+autocc, glenn, hyatt, jonlee, kondapallykalyan, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 142608 | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2015-03-31 21:31:37 PDT
Created attachment 249888 [details]
Patch
Comment on attachment 249888 [details]
Patch
r=me
Comment on attachment 249888 [details] Patch Clearing flags on attachment: 249888 Committed r182236: <http://trac.webkit.org/changeset/182236> All reviewed patches have been landed. Closing bug. Comment on attachment 249888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249888&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:1124 > + if (!stringView.is8Bit() && U16_IS_LEAD(initialCharacter) && stringView.length() > 1 && U16_IS_TRAIL(stringView[1])) The is8Bit check here is unneeded extra code. > Source/WebCore/platform/graphics/FontCascade.cpp:1128 > + if (!stringView.is8Bit() && U16_IS_TRAIL(initialCharacter) && stringView.length() > 1 && U16_IS_LEAD(stringView[stringView.length() - 2])) The is8Bit check here is unneeded extra code. > Source/WebCore/platform/graphics/FontCascade.cpp:1143 > + if (!stringView.is8Bit() && U16_IS_TRAIL(finalCharacter) && stringView.length() > 1 && U16_IS_LEAD(stringView[stringView.length() - 2])) The is8Bit check here is unneeded extra code. > Source/WebCore/platform/graphics/FontCascade.cpp:1147 > + if (!stringView.is8Bit() && U16_IS_LEAD(finalCharacter) && stringView.length() > 1 && U16_IS_TRAIL(stringView[1])) The is8Bit check here is unneeded extra code. > Source/WebCore/platform/graphics/FontCascade.h:199 > + static std::pair<unsigned, bool> expansionOpportunityCount(const StringView&, TextDirection, ExpansionBehavior); Not sure why you chose pair over tuple here for return value. Comment on attachment 249888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249888&action=review >> Source/WebCore/platform/graphics/FontCascade.cpp:1124 >> + if (!stringView.is8Bit() && U16_IS_LEAD(initialCharacter) && stringView.length() > 1 && U16_IS_TRAIL(stringView[1])) > > The is8Bit check here is unneeded extra code. Done. >> Source/WebCore/platform/graphics/FontCascade.cpp:1128 >> + if (!stringView.is8Bit() && U16_IS_TRAIL(initialCharacter) && stringView.length() > 1 && U16_IS_LEAD(stringView[stringView.length() - 2])) > > The is8Bit check here is unneeded extra code. Done. >> Source/WebCore/platform/graphics/FontCascade.cpp:1143 >> + if (!stringView.is8Bit() && U16_IS_TRAIL(finalCharacter) && stringView.length() > 1 && U16_IS_LEAD(stringView[stringView.length() - 2])) > > The is8Bit check here is unneeded extra code. Done. >> Source/WebCore/platform/graphics/FontCascade.cpp:1147 >> + if (!stringView.is8Bit() && U16_IS_LEAD(finalCharacter) && stringView.length() > 1 && U16_IS_TRAIL(stringView[1])) > > The is8Bit check here is unneeded extra code. Done. >> Source/WebCore/platform/graphics/FontCascade.h:199 >> + static std::pair<unsigned, bool> expansionOpportunityCount(const StringView&, TextDirection, ExpansionBehavior); > > Not sure why you chose pair over tuple here for return value. There is no need for a tuple; pairs require exactly two inner types and tuples allow for an arbitrary number. However, I only need two. AFAIK, that's the only relevant difference between pair and tuple. Committed r182238: <http://trac.webkit.org/changeset/182238> |