Bug 143292 – Support forcing expansion opportunities at the beginning and ending of a run

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Support forcing expansion opportunities at the beginning and ending of a run

[Myles C. Maxfield]

Created attachment 249888 [details]
Patch

[Dave Hyatt]

Comment on attachment 249888 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 249888 [details]
Patch

Clearing flags on attachment: 249888

Committed r182236: <http://trac.webkit.org/changeset/182236>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 249888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249888&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:1124
> +        if (!stringView.is8Bit() && U16_IS_LEAD(initialCharacter) && stringView.length() > 1 && U16_IS_TRAIL(stringView[1]))

The is8Bit check here is unneeded extra code.

> Source/WebCore/platform/graphics/FontCascade.cpp:1128
> +        if (!stringView.is8Bit() && U16_IS_TRAIL(initialCharacter) && stringView.length() > 1 && U16_IS_LEAD(stringView[stringView.length() - 2]))

The is8Bit check here is unneeded extra code.

> Source/WebCore/platform/graphics/FontCascade.cpp:1143
> +        if (!stringView.is8Bit() && U16_IS_TRAIL(finalCharacter) && stringView.length() > 1 && U16_IS_LEAD(stringView[stringView.length() - 2]))

The is8Bit check here is unneeded extra code.

> Source/WebCore/platform/graphics/FontCascade.cpp:1147
> +        if (!stringView.is8Bit() && U16_IS_LEAD(finalCharacter) && stringView.length() > 1 && U16_IS_TRAIL(stringView[1]))

The is8Bit check here is unneeded extra code.

> Source/WebCore/platform/graphics/FontCascade.h:199
> +    static std::pair<unsigned, bool> expansionOpportunityCount(const StringView&, TextDirection, ExpansionBehavior);

Not sure why you chose pair over tuple here for return value.

[Myles C. Maxfield]

Comment on attachment 249888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249888&action=review

>> Source/WebCore/platform/graphics/FontCascade.cpp:1124
>> +        if (!stringView.is8Bit() && U16_IS_LEAD(initialCharacter) && stringView.length() > 1 && U16_IS_TRAIL(stringView[1]))
> 
> The is8Bit check here is unneeded extra code.

Done.

>> Source/WebCore/platform/graphics/FontCascade.cpp:1128
>> +        if (!stringView.is8Bit() && U16_IS_TRAIL(initialCharacter) && stringView.length() > 1 && U16_IS_LEAD(stringView[stringView.length() - 2]))
> 
> The is8Bit check here is unneeded extra code.

Done.

>> Source/WebCore/platform/graphics/FontCascade.cpp:1143
>> +        if (!stringView.is8Bit() && U16_IS_TRAIL(finalCharacter) && stringView.length() > 1 && U16_IS_LEAD(stringView[stringView.length() - 2]))
> 
> The is8Bit check here is unneeded extra code.

Done.

>> Source/WebCore/platform/graphics/FontCascade.cpp:1147
>> +        if (!stringView.is8Bit() && U16_IS_LEAD(finalCharacter) && stringView.length() > 1 && U16_IS_TRAIL(stringView[1]))
> 
> The is8Bit check here is unneeded extra code.

Done.

>> Source/WebCore/platform/graphics/FontCascade.h:199
>> +    static std::pair<unsigned, bool> expansionOpportunityCount(const StringView&, TextDirection, ExpansionBehavior);
> 
> Not sure why you chose pair over tuple here for return value.

There is no need for a tuple; pairs require exactly two inner types and tuples allow for an arbitrary number. However, I only need two. AFAIK, that's the only relevant difference between pair and tuple.

[Myles C. Maxfield]

Committed r182238: <http://trac.webkit.org/changeset/182238>