| Summary: | Web Inspector: spacebar should pause/resume timeline recording when timelines are open | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Brian Burg
2015-03-31 10:07:43 PDT
Created attachment 256312 [details]
Patch
Comment on attachment 256312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256312&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:37 > + this._toggleRecordingShortcut = new WebInspector.KeyboardShortcut(null, WebInspector.KeyboardShortcut.Key.Space, this._toggleRecordingOnSpacebar.bind(this)); > + this._toggleRecordingShortcut.implicitlyPreventsDefault = false; > + > + this._toggleNewRecordingShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.Space, this._toggleNewRecordingOnSpacebar.bind(this)); > + this._toggleNewRecordingShortcut.implicitlyPreventsDefault = false; We should mention the shortcuts in a tooltip on the Record button in the sidebar. It might be easier to put this code in TimelineSidebarPanel, since it also toggles recording and you would have access to the shortcuts to use displayName for the tooltip. Created attachment 256344 [details]
Patch
Comment on attachment 256344 [details] Patch Clearing flags on attachment: 256344 Committed r186489: <http://trac.webkit.org/changeset/186489> All reviewed patches have been landed. Closing bug. |