Bug 143267 – Web Inspector: spacebar should pause/resume timeline recording when timelines are open

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Brian Burg]

.. and focus isn't somewhere else, like a search field.

[Radar WebKit Bug Importer]

<rdar://problem/20365499>

[Devin Rousso]

Created attachment 256312 [details]
Patch

[Timothy Hatcher]

Comment on attachment 256312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256312&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:37
> +    this._toggleRecordingShortcut = new WebInspector.KeyboardShortcut(null, WebInspector.KeyboardShortcut.Key.Space, this._toggleRecordingOnSpacebar.bind(this));
> +    this._toggleRecordingShortcut.implicitlyPreventsDefault = false;
> +
> +    this._toggleNewRecordingShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.Space, this._toggleNewRecordingOnSpacebar.bind(this));
> +    this._toggleNewRecordingShortcut.implicitlyPreventsDefault = false;

We should mention the shortcuts in a tooltip on the Record button in the sidebar. It might be easier to put this code in TimelineSidebarPanel, since it also toggles recording and you would have access to the shortcuts to use displayName for the tooltip.

[Devin Rousso]

Created attachment 256344 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 256344 [details]
Patch

Clearing flags on attachment: 256344

Committed r186489: <http://trac.webkit.org/changeset/186489>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.