Bug 143240

Summary: When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ddkilzer, glenn, msaboff, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2015-03-30 16:10:10 PDT
I've seen a machine where LayoutTestHelper crashes on launch because of some color profile misconfiguration. But we still run the tests, and fail some, because LayoutTestHelper couldn't set a proper color profile.
Attachments
proposed fix (5.38 KB, patch)
2015-03-30 16:17 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-03-30 16:17:46 PDT
Created attachment 249780 [details] proposed fix
Alexey Proskuryakov
Comment 2 2015-03-30 16:17:57 PDT
rdar://problem/19990425
WebKit Commit Bot
Comment 3 2015-04-01 23:29:14 PDT
Comment on attachment 249780 [details] proposed fix Clearing flags on attachment: 249780 Committed r182268: <http://trac.webkit.org/changeset/182268>
WebKit Commit Bot
Comment 4 2015-04-01 23:29:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.