Bug 143240

Summary:

When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, ddkilzer, glenn, msaboff, thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2015-03-30 16:10:10 PDT

I've seen a machine where LayoutTestHelper crashes on launch because of some color profile misconfiguration. But we still run the tests, and fail some, because LayoutTestHelper couldn't set a proper color profile.

Comment 1 Alexey Proskuryakov 2015-03-30 16:17:46 PDT

Created attachment 249780 [details]
proposed fix

Comment 2 Alexey Proskuryakov 2015-03-30 16:17:57 PDT

rdar://problem/19990425

Comment 3 WebKit Commit Bot 2015-04-01 23:29:14 PDT

Comment on attachment 249780 [details]
proposed fix

Clearing flags on attachment: 249780

Committed r182268: <http://trac.webkit.org/changeset/182268>

Comment 4 WebKit Commit Bot 2015-04-01 23:29:19 PDT

All reviewed patches have been landed.  Closing bug.