Bug 143240 - When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
Summary: When LayoutTestHelper fails to start, we continue to run the tests, ending up...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-30 16:10 PDT by Alexey Proskuryakov
Modified: 2015-04-01 23:29 PDT (History)
6 users (show)

See Also:


Attachments
proposed fix (5.38 KB, patch)
2015-03-30 16:17 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-03-30 16:10:10 PDT
I've seen a machine where LayoutTestHelper crashes on launch because of some color profile misconfiguration. But we still run the tests, and fail some, because LayoutTestHelper couldn't set a proper color profile.
Comment 1 Alexey Proskuryakov 2015-03-30 16:17:46 PDT
Created attachment 249780 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2015-03-30 16:17:57 PDT
rdar://problem/19990425
Comment 3 WebKit Commit Bot 2015-04-01 23:29:14 PDT
Comment on attachment 249780 [details]
proposed fix

Clearing flags on attachment: 249780

Committed r182268: <http://trac.webkit.org/changeset/182268>
Comment 4 WebKit Commit Bot 2015-04-01 23:29:19 PDT
All reviewed patches have been landed.  Closing bug.