Bug 143238

Summary:

[New Block-Inside-Inline Model] Make sure breaks occur both before and after the anonymous inline-block

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, mmaxfield

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dino: review+

Description Dave Hyatt 2015-03-30 15:02:30 PDT

Make sure line breaks occur both before and after the anonymous inline-block.

Comment 1 Dave Hyatt 2015-03-30 15:08:11 PDT

Created attachment 249769 [details]
Patch

Comment 2 Dave Hyatt 2015-03-31 10:43:20 PDT

Fixed in r182188.

Comment 3 Jon Lee 2015-03-31 11:21:58 PDT

Comment on attachment 249769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249769&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:4118
> +                if (((canBreakReplacedElement && (autoWrap || oldAutoWrap) && (!isPrevChildInlineFlow || shouldBreakLineAfterText)) || clearPreviousFloat) || isAnonymousInlineBlock) {

is the extra parenthesis necessary? you've got ((...) || clearPreviousFloat || isAnonymousInlineBlock)