Bug 143235

Summary: [Content Extensions] Correctly handle regular expressions matching everything
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebCore Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+

Description Alex Christensen 2015-03-30 13:23:20 PDT 
There are lots of edge cases.  They should be fixed and tested.
Comment 1 Alex Christensen 2015-03-30 13:36:03 PDT 
Created attachment 249758 [details]
Patch
Comment 2 Benjamin Poulain 2015-03-30 17:09:59 PDT 
Comment on attachment 249758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249758&action=review

> Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:61
> +        for (unsigned i = 0; i < selectorLength; i++) {

++i

> Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:62
> +            actions.resize(actions.size() + sizeof(UChar));

Probably best doing this out of the loop.

> Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:66
> +        for (unsigned i = 0; i < selectorLength; i++)

++i

> Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:89
> +                    selector.append(",");

','
Comment 3 Alex Christensen 2015-03-30 17:49:36 PDT 
http://trac.webkit.org/changeset/182168