Bug 143231

Summary: WebBackForwardList doesn't need to manually clear the snapshot of an entry when removing it.
Product: WebKit Reporter: Andreas Kling <kling>
Component: HistoryAssignee: Andreas Kling <kling>
Status: REOPENED ---    
Severity: Normal CC: andersca, commit-queue, kling, mitz, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 143250    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Andreas Kling 2015-03-30 11:11:41 PDT
No need to setSnapshot(nullptr) when removing an item from the WebBackForwardList now that items actually get destroyed right after.
Comment 1 Andreas Kling 2015-03-30 11:12:06 PDT
Created attachment 249748 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-30 20:03:29 PDT
Comment on attachment 249748 [details]
Patch

Clearing flags on attachment: 249748

Committed r182172: <http://trac.webkit.org/changeset/182172>
Comment 3 WebKit Commit Bot 2015-03-30 20:03:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 mitz 2015-03-30 20:09:36 PDT
Isn’t WebBackForwardListItem an API object? A client may hold on to arbitrarily many instances but will have no way to get to the snapshots. This suggests that dropping the reference to the snapshot once the item is not in the list could still be beneficial.
Comment 5 Andreas Kling 2015-03-30 20:21:07 PDT
(In reply to comment #4)
> Isn’t WebBackForwardListItem an API object? A client may hold on to
> arbitrarily many instances but will have no way to get to the snapshots.
> This suggests that dropping the reference to the snapshot once the item is
> not in the list could still be beneficial.

Oh! I did not realize that WebBackForwardListItem was exposed through the modern WebKit API. Rolling this out.
Comment 6 WebKit Commit Bot 2015-03-30 20:24:21 PDT
Re-opened since this is blocked by bug 143250