Bug 143184

Summary:

Add script to graph GC phase timings

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenb>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenb>

Status:

NEW ---

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Mark Hahnenberg 2015-03-28 09:31:00 PDT

This can make it easier to quickly see which particular GC phases are taking the most time and would therefore benefit the most from further scrutiny and improvement.

Comment 1 Mark Hahnenberg 2015-03-28 09:41:43 PDT

Created attachment 249662 [details]
Patch

Comment 2 WebKit Commit Bot 2015-03-28 09:43:26 PDT

Attachment 249662 [details] did not pass style-queue:


ERROR: Tools/Scripts/gctools/graph_phase_timings.py:66:  [graph_timings] Passing unexpected keyword argument 'startangle' in function call  [pylint/E1123] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Andreas Kling 2015-04-24 23:00:26 PDT

Comment on attachment 249662 [details]
Patch

rs=me