Bug 143176

Summary:

Web Inspector: Adopt Array.prototype.includes and String.prototype.includes

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, graouts, joepeck, jonowells, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Archive of layout-test-results from ews101 for mac-mavericks	none
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2015-03-27 23:40:39 PDT

* SUMMARY Adopt Array.prototype.includes and String.prototype.includes instead of our own implementations of Array.prototype.contains and String.prototype.contains. - The subtle differences in implementation shouldn't affect us. - Not to be confused with Element.prototype.contains and DOMTokenList.prototype.contains (classList).

Attachments
[PATCH] Proposed Fix (28.95 KB, patch) 2015-03-27 23:42 PDT, Joseph Pecoraro	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (563.41 KB, application/zip) 2015-03-28 00:18 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-mavericks (523.04 KB, application/zip) 2015-03-28 00:30 PDT, Build Bot	no flags	Details
[PATCH] Proposed Fix (30.09 KB, patch) 2015-03-28 01:13 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-03-27 23:41:02 PDT

<rdar://problem/20336710>

Joseph Pecoraro

Comment 2 2015-03-27 23:42:31 PDT

Created attachment 249646 [details] [PATCH] Proposed Fix

Build Bot

Comment 3 2015-03-28 00:18:42 PDT

Comment on attachment 249646 [details] [PATCH] Proposed Fix Attachment 249646 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4621473318699008 New failing tests: inspector/css/pseudo-element-matches.html

Build Bot

Comment 4 2015-03-28 00:18:47 PDT

Created attachment 249650 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-03-28 00:30:29 PDT

Comment on attachment 249646 [details] [PATCH] Proposed Fix Attachment 249646 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6102388779778048 New failing tests: inspector/css/pseudo-element-matches.html

Build Bot

Comment 6 2015-03-28 00:30:32 PDT

Created attachment 249651 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Joseph Pecoraro

Comment 7 2015-03-28 01:10:44 PDT

> New failing tests: > inspector/css/pseudo-element-matches.html Wow, I didn't think the tests might use these functions, but they do! This was the only occurrence.

Joseph Pecoraro

Comment 8 2015-03-28 01:13:22 PDT

Created attachment 249654 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 9 2015-03-28 09:38:45 PDT

Comment on attachment 249654 [details] [PATCH] Proposed Fix Clearing flags on attachment: 249654 Committed r182113: <http://trac.webkit.org/changeset/182113>

WebKit Commit Bot

Comment 10 2015-03-28 09:38:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.