Bug 143173

Summary: [GTK] Web Inspector: New Images for ObjectTreeView - Setter
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Andres Gomez Garcia <agomez>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, cgarcia, commit-queue, graouts, gustavo, joepeck, jonowells, mattbaker, mrobinson, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Joseph Pecoraro
Reported 2015-03-27 20:00:51 PDT
* SUMMARY New Images for ObjectTreeView - Setter. "Pencil.svg". Added in <http://trac.webkit.org/changeset/182099> * TEST Foo = class Foo { constructor() { this.value = 1; } get getterOnly() {} get getterAndSetter() {} set getterAndSetter(x) {} set setterOnly(x) {} } foo = new Foo; Object.defineProperty(foo, 'value', { value: 1 }); Object.defineProperty(foo, 'getterOnly', { get: function(){ return 2; } }); Object.defineProperty(foo, 'getterAndSetter', { get: function(){ return 2; }, set(x){} }); Object.defineProperty(foo, 'setterOnly', { set(x){} }); foo; * STEPS TO REPRODUCE 1. Evaluate the test in the console 2. Expand the object => "setterOnly" fields should have icons
Attachments
Patch (1.81 KB, patch)
2015-04-30 10:09 PDT, Andres Gomez Garcia
no flags
Radar WebKit Bug Importer
Comment 1 2015-03-27 20:01:22 PDT
Joseph Pecoraro
Comment 2 2015-03-27 20:01:52 PDT
See: <https://webkit.org/b/143129> Web Inspector: Add Setter Icon for ObjectTreeView
Andres Gomez Garcia
Comment 3 2015-04-07 04:22:05 PDT
Getting. Thanks for the report!
Andres Gomez Garcia
Comment 4 2015-04-30 10:09:31 PDT
WebKit Commit Bot
Comment 5 2015-04-30 11:02:07 PDT
Comment on attachment 252067 [details] Patch Clearing flags on attachment: 252067 Committed r183633: <http://trac.webkit.org/changeset/183633>
WebKit Commit Bot
Comment 6 2015-04-30 11:02:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.