Bug 143173

Summary:

[GTK] Web Inspector: New Images for ObjectTreeView - Setter

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Andres Gomez Garcia <agomez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, cgarcia, commit-queue, graouts, gustavo, joepeck, jonowells, mattbaker, mrobinson, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Joseph Pecoraro 2015-03-27 20:00:51 PDT

* SUMMARY
New Images for ObjectTreeView - Setter. "Pencil.svg". Added in <http://trac.webkit.org/changeset/182099>

* TEST
Foo = class Foo {
    constructor() { this.value = 1; }
    get getterOnly() {}
    get getterAndSetter() {}
    set getterAndSetter(x) {}
    set setterOnly(x) {}
}
foo = new Foo;
Object.defineProperty(foo, 'value', { value: 1 });
Object.defineProperty(foo, 'getterOnly', { get: function(){ return 2; } });
Object.defineProperty(foo, 'getterAndSetter', { get: function(){ return 2; }, set(x){} });
Object.defineProperty(foo, 'setterOnly', { set(x){} });
foo;

* STEPS TO REPRODUCE
1. Evaluate the test in the console
2. Expand the object
  => "setterOnly" fields should have icons

Comment 1 Radar WebKit Bug Importer 2015-03-27 20:01:22 PDT

<rdar://problem/20336142>

Comment 2 Joseph Pecoraro 2015-03-27 20:01:52 PDT

See: <https://webkit.org/b/143129> Web Inspector: Add Setter Icon for ObjectTreeView

Comment 3 Andres Gomez Garcia 2015-04-07 04:22:05 PDT

Getting.

Thanks for the report!

Comment 4 Andres Gomez Garcia 2015-04-30 10:09:31 PDT

Created attachment 252067 [details]
Patch

Comment 5 WebKit Commit Bot 2015-04-30 11:02:07 PDT

Comment on attachment 252067 [details]
Patch

Clearing flags on attachment: 252067

Committed r183633: <http://trac.webkit.org/changeset/183633>

Comment 6 WebKit Commit Bot 2015-04-30 11:02:15 PDT

All reviewed patches have been landed.  Closing bug.