Summary: | Web Inspector: TypeProfiler doesn't work on files with ES6 Class Syntax | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, saam, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2015-03-27 18:05:00 PDT
Created attachment 249631 [details]
[PATCH] Proposed Fix
Comment on attachment 249631 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=249631&action=review Looks correct to me besides adding the one bit regarding setter/getter methods. > Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js:715 > + }; Like what's done with "Property" below, we should do: if (result.kind === "get" || result.kind === "set") { result.value.isGetterOrSetter = true; result.value.getterOrSetterRange = result.key.range; } Created attachment 249637 [details]
[PATCH] Proposed Fix
Good comment, that greatly fixed up my test case.
Created attachment 249638 [details]
[IMAGE] What it looks like
Comment on attachment 249637 [details] [PATCH] Proposed Fix Clearing flags on attachment: 249637 Committed r182106: <http://trac.webkit.org/changeset/182106> All reviewed patches have been landed. Closing bug. |