Bug 143166

Summary:

Web Inspector: Console should indicate if you have unseen messages in console due to filters

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mark.lam, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
After Patch is applied	none
Patch	none

Joseph Pecoraro

Reported 2015-03-27 17:28:21 PDT

* SUMMARY Console should indicate if you have unseen messages in console due to filters. I frequently think "where are my messages" before noticing that there is a filter that is hiding them. I've frequently had people come to me with the same problem. We should better indicate when a filter is hiding messages.

Attachments
Patch (12.74 KB, patch) 2015-07-02 16:54 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
After Patch is applied (48.87 KB, image/png) 2015-07-04 10:11 PDT, Devin Rousso	no flags	Details
Patch (12.74 KB, patch) 2015-07-04 10:12 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-03-27 17:28:44 PDT

<rdar://problem/20335055>

Devin Rousso

Comment 2 2015-07-02 16:54:31 PDT

Created attachment 256050 [details] Patch

Timothy Hatcher

Comment 3 2015-07-02 18:18:19 PDT

Can you post a screenshot?

Timothy Hatcher

Comment 4 2015-07-04 07:06:15 PDT

Comment on attachment 256050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256050&action=review > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:35 > + border-color: rgba(224, 164, 4, 0.9); Why rgba here and not for the others? > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:324 > + _determineMessageLevel: function(level) _scopeFromMessageLevel?

Devin Rousso

Comment 5 2015-07-04 10:06:44 PDT

Comment on attachment 256050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256050&action=review >> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:35 >> + border-color: rgba(224, 164, 4, 0.9); > > Why rgba here and not for the others? I was originally using the color of the warning icon in the inspector status area, but I'll look to see if I can find a better color.

Devin Rousso

Comment 6 2015-07-04 10:11:50 PDT

Created attachment 256150 [details] After Patch is applied

Devin Rousso

Comment 7 2015-07-04 10:12:29 PDT

Created attachment 256151 [details] Patch

WebKit Commit Bot

Comment 8 2015-07-04 14:47:30 PDT

Comment on attachment 256151 [details] Patch Clearing flags on attachment: 256151 Committed r186283: <http://trac.webkit.org/changeset/186283>

WebKit Commit Bot

Comment 9 2015-07-04 14:47:34 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.