Bug 143145

Summary: [New Block-Inside-Inline Model] Create an anonymous inline block to hold blocks-inside-inlines
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Dave Hyatt
Reported 2015-03-27 13:01:22 PDT
Create anonymous inline-blocks in order to act as containers for blocks-inside-inlines. This allows them to sit on a line and actually be properly contained within the render tree hierarchy without splitting inlines or creating continuations.
Attachments
Patch (10.70 KB, patch)
2015-03-27 13:05 PDT, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2015-03-27 13:05:23 PDT
Created attachment 249600 [details] Patch
WebKit Commit Bot
Comment 2 2015-03-27 13:07:56 PDT
Attachment 249600 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderInline.cpp:370: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/rendering/RenderInline.cpp:382: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderInline.cpp:384: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2015-03-30 11:03:39 PDT
Fixed in r182146.
Note You need to log in before you can comment on or make changes to this bug.