Bug 143145

Summary:

[New Block-Inside-Inline Model] Create an anonymous inline block to hold blocks-inside-inlines

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dino: review+

Description Dave Hyatt 2015-03-27 13:01:22 PDT

Create anonymous inline-blocks in order to act as containers for blocks-inside-inlines. This allows them to sit on a line and actually be properly contained within the render tree hierarchy without splitting inlines or creating continuations.

Comment 1 Dave Hyatt 2015-03-27 13:05:23 PDT

Created attachment 249600 [details]
Patch

Comment 2 WebKit Commit Bot 2015-03-27 13:07:56 PDT

Attachment 249600 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderInline.cpp:370:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:382:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderInline.cpp:384:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Dave Hyatt 2015-03-30 11:03:39 PDT

Fixed in r182146.