Bug 143144

Summary: Null dereference in InbandMetadataTextTrack handling
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson, jer.noble, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Brent Fulgham
Reported 2015-03-27 12:45:02 PDT
We've seen some crashes due to a null dereference in InbandMetadataTextTrackAVF::updatePendingCueEndTimes. Reviewing the code, I notice that the client() return value is used without null check, even though the other methods in this class due check for null. This patch adds a null check for client()'s return value to avoid this crash.
Attachments
Patch (2.56 KB, patch)
2015-03-27 12:49 PDT, Brent Fulgham 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-03-27 12:45:25 PDT
<rdar://problem/18983250>
Brent Fulgham
Comment 2 2015-03-27 12:49:55 PDT
Created attachment 249598 [details] Patch
Brent Fulgham
Comment 3 2015-03-27 13:42:15 PDT
Committed r182076: <http://trac.webkit.org/changeset/182076>
Note You need to log in before you can comment on or make changes to this bug.