Bug 143138

Summary: [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Gyuyoung Kim
Reported 2015-03-27 11:01:41 PDT
INCLUDE_IF_EXISTS isn't used except for 2 places. However the uses can be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
Attachments
Patch (5.13 KB, patch)
2015-03-27 11:03 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.48 KB, patch)
2015-03-27 19:39 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-03-27 11:03:31 PDT
Created attachment 249586 [details] Patch
Csaba Osztrogonác
Comment 2 2015-03-27 11:23:43 PDT
Comment on attachment 249586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review LGTM, r=me with a minor change. > Tools/DumpRenderTree/CMakeLists.txt:-72 > -WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() > - I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once. Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" )
Alex Christensen
Comment 3 2015-03-27 11:31:26 PDT
Comment on attachment 249586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review >> Tools/DumpRenderTree/CMakeLists.txt:-72 >> - > > I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once. > Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" ) None of the CMake ports use DumpRenderTree anymore, right? We could remove this file completely, but I'd just have to add it again once somebody (probably me) gets Mac and Windows working with CMake. Let's just leave it alone right now and I'll get to it.
Gyuyoung Kim
Comment 4 2015-03-27 19:39:28 PDT
Created attachment 249640 [details] Patch for landing
Gyuyoung Kim
Comment 5 2015-03-27 19:40:54 PDT
Comment on attachment 249586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review >>> Tools/DumpRenderTree/CMakeLists.txt:-72 >>> - >> >> I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once. >> Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" ) > > None of the CMake ports use DumpRenderTree anymore, right? We could remove this file completely, but I'd just have to add it again once somebody (probably me) gets Mac and Windows working with CMake. Let's just leave it alone right now and I'll get to it. I see. Let's leave it as is for upcoming PlatformFoo.cmake use.
WebKit Commit Bot
Comment 6 2015-03-27 21:18:58 PDT
Comment on attachment 249640 [details] Patch for landing Clearing flags on attachment: 249640 Committed r182103: <http://trac.webkit.org/changeset/182103>
WebKit Commit Bot
Comment 7 2015-03-27 21:19:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.