| Summary: | [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Component: | Tools / Tests | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Gyuyoung Kim
2015-03-27 11:01:41 PDT
Created attachment 249586 [details]
Patch
Comment on attachment 249586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review LGTM, r=me with a minor change. > Tools/DumpRenderTree/CMakeLists.txt:-72 > -WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() > - I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once. Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" ) Comment on attachment 249586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review >> Tools/DumpRenderTree/CMakeLists.txt:-72 >> - > > I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once. > Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" ) None of the CMake ports use DumpRenderTree anymore, right? We could remove this file completely, but I'd just have to add it again once somebody (probably me) gets Mac and Windows working with CMake. Let's just leave it alone right now and I'll get to it. Created attachment 249640 [details]
Patch for landing
Comment on attachment 249586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review >>> Tools/DumpRenderTree/CMakeLists.txt:-72 >>> - >> >> I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once. >> Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" ) > > None of the CMake ports use DumpRenderTree anymore, right? We could remove this file completely, but I'd just have to add it again once somebody (probably me) gets Mac and Windows working with CMake. Let's just leave it alone right now and I'll get to it. I see. Let's leave it as is for upcoming PlatformFoo.cmake use. Comment on attachment 249640 [details] Patch for landing Clearing flags on attachment: 249640 Committed r182103: <http://trac.webkit.org/changeset/182103> All reviewed patches have been landed. Closing bug. |