Bug 143120

Summary: Optimized Fullscreen fails to cleanup becuase of no longer necessary release of m_playerController in exitFullscreen()
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing. none

Jeremy Jones
Reported 2015-03-26 16:31:33 PDT
Optimized Fullscreen fails to cleanup becuase of no longer necessary release of m_playerController in exitFullscreen()
Attachments
Patch (1.93 KB, patch)
2015-03-26 16:36 PDT, Jeremy Jones 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing. (1.93 KB, patch)
2015-03-26 22:44 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2015-03-26 16:36:01 PDT
Created attachment 249540 [details] Patch
Jeremy Jones
Comment 2 2015-03-26 16:37:07 PDT
rdar://problem/19445613
Eric Carlson
Comment 3 2015-03-26 17:29:12 PDT
Comment on attachment 249540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249540&action=review > Source/WebCore/ChangeLog:11 > + WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releaseing it prematurely can actually prevent the exit Nit: "Releaseing"-" "Releasing"
Jon Lee
Comment 4 2015-03-26 18:38:11 PDT
rdar://problem/20263463
Jeremy Jones
Comment 5 2015-03-26 22:43:54 PDT
(In reply to comment #3) > Comment on attachment 249540 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249540&action=review > > > Source/WebCore/ChangeLog:11 > > + WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releaseing it prematurely can actually prevent the exit > > Nit: "Releaseing"-" "Releasing" Fixes that and three other typos!
Jeremy Jones
Comment 6 2015-03-26 22:44:00 PDT
Created attachment 249552 [details] Patch for landing.
WebKit Commit Bot
Comment 7 2015-03-26 23:37:32 PDT
Comment on attachment 249552 [details] Patch for landing. Clearing flags on attachment: 249552 Committed r182052: <http://trac.webkit.org/changeset/182052>
Note You need to log in before you can comment on or make changes to this bug.