| Summary: | Optimized Fullscreen fails to cleanup becuase of no longer necessary release of m_playerController in exitFullscreen() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||
| Component: | Media | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, jer.noble, jonlee, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | iPhone / iPad | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jeremy Jones
2015-03-26 16:31:33 PDT
Created attachment 249540 [details]
Patch
Comment on attachment 249540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249540&action=review > Source/WebCore/ChangeLog:11 > + WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releaseing it prematurely can actually prevent the exit Nit: "Releaseing"-" "Releasing" (In reply to comment #3) > Comment on attachment 249540 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249540&action=review > > > Source/WebCore/ChangeLog:11 > > + WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releaseing it prematurely can actually prevent the exit > > Nit: "Releaseing"-" "Releasing" Fixes that and three other typos! Created attachment 249552 [details]
Patch for landing.
Comment on attachment 249552 [details] Patch for landing. Clearing flags on attachment: 249552 Committed r182052: <http://trac.webkit.org/changeset/182052> |