| Summary: | Apply blur effect to media control background | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||||||||
| Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, buildbot, dino, rniwa, roger_fong | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Roger Fong
2015-03-26 15:20:52 PDT
Created attachment 249519 [details]
patch
Comment on attachment 249519 [details] patch Attachment 249519 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5696776363311104 New failing tests: media/video-volume-slider-drag.html http/tests/media/hls/video-controls-live-stream.html fullscreen/video-controls-override.html Created attachment 249523 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 249519 [details] patch Attachment 249519 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5629456240607232 New failing tests: media/video-volume-slider-drag.html http/tests/media/hls/video-controls-live-stream.html fullscreen/video-controls-override.html Created attachment 249526 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 249532 [details]
patch
Comment on attachment 249532 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=249532&action=review r=me > Source/WebCore/ChangeLog:10 > + and the volume slider background not showing the blur effect. Iâll fix those separately. Bad character in ChangeLog. --> I'll > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1132 > + ctx.fillStyle = "rgba(140, 140, 140, .68)"; I think we usually write this as "0.68", not ".68" > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1193 > + ctx.fillStyle = "rgba(140, 140, 140, .68)"; Ditto the leading zero. (.68 -> 0.68) |