Bug 143107

Summary: Web Inspector: Convert some View classes to ES6 classes
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 142891    
Attachments:
Description Flags
Patch
none
Patch
none
Patch joepeck: review+

Description Timothy Hatcher 2015-03-26 11:05:59 PDT
Some of the simple View classes can be converted now. The rest are harder.
Comment 1 Radar WebKit Bug Importer 2015-03-26 11:06:40 PDT
<rdar://problem/20311871>
Comment 2 Timothy Hatcher 2015-03-26 11:11:29 PDT
Created attachment 249497 [details]
Patch
Comment 3 Timothy Hatcher 2015-03-26 11:11:53 PDT
Created attachment 249498 [details]
Patch
Comment 4 Timothy Hatcher 2015-03-26 11:19:07 PDT
Created attachment 249501 [details]
Patch
Comment 5 Joseph Pecoraro 2015-03-26 11:49:44 PDT
Comment on attachment 249501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249501&action=review

r=me

> Source/WebInspectorUI/ChangeLog:41
> +        Converted to ES6 ckasses.

Typo: "ckasses" => "classes"

> Source/WebInspectorUI/UserInterface/Views/ContextMenu.js:150
> +    constructor(event) {

Nit: Style, brace should be on newline.

> Source/WebInspectorUI/UserInterface/Views/EditingSupport.js:81
> +        this.commitHandler = commitHandler;

Could make these _foo.

> Source/WebInspectorUI/UserInterface/Views/GoToLineDialog.js:122
> +            event.preventDefault();

Is this fixing a bug?

> Source/WebInspectorUI/UserInterface/Views/SearchBar.js:47
> +        this._searchInput.addEventListener("search", this._handleSearchEvent.bind(this), false);
> +        this._searchInput.addEventListener("keydown", this._handleKeydownEvent.bind(this), false);

Style: I think we have been dropping the false for useCapture for addEventListener. We can update that here.
Comment 6 Timothy Hatcher 2015-03-26 16:40:07 PDT
Comment on attachment 249501 [details]
Patch

https://trac.webkit.org/r182040