Bug 143106

Summary:

Web Inspector: Convert Base and Protocol files to ES6 classes

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

142891

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	joepeck: review+

Description Timothy Hatcher 2015-03-26 10:53:10 PDT

Do it! It is much simpler than Views.

Comment 1 Radar WebKit Bug Importer 2015-03-26 10:53:38 PDT

<rdar://problem/20311614>

Comment 2 Timothy Hatcher 2015-03-26 10:56:17 PDT

Created attachment 249496 [details]
Patch

Comment 3 Timothy Hatcher 2015-03-26 11:14:40 PDT

Created attachment 249499 [details]
Patch

Comment 4 Timothy Hatcher 2015-03-26 11:17:47 PDT

Created attachment 249500 [details]
Patch

Comment 5 WebKit Commit Bot 2015-03-26 11:20:42 PDT

Attachment 249500 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:362:  Line contains single-quote character.  [js/syntax] [5]
ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:376:  Line contains single-quote character.  [js/syntax] [5]
ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:422:  Line contains single-quote character.  [js/syntax] [5]
ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:430:  Line contains single-quote character.  [js/syntax] [5]
ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:450:  Line contains single-quote character.  [js/syntax] [5]
ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:462:  Line contains single-quote character.  [js/syntax] [5]
Total errors found: 6 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Joseph Pecoraro 2015-03-26 11:25:42 PDT

Comment on attachment 249499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249499&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/EventListenerSet.js:36
> +        this.name = name;

Should we fix this to be "_name"?

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:362
> +    'use strict';

Style: Double quotes.

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:508
> +        this.eventName = eventName;
> +        this.parameterNames = parameterNames;

Nit: _foo?

> Source/WebInspectorUI/UserInterface/Protocol/MessageDispatcher.js:27
> -WebInspector.messagesToDispatch = [];
> +WebInspector._messagesToDispatch = [];

Doh, I rather liked this one without the underscore.

Comment 7 Joseph Pecoraro 2015-03-26 11:26:17 PDT

Comment on attachment 249500 [details]
Patch

Same comments probably apply.

Comment 8 Timothy Hatcher 2015-03-26 16:39:09 PDT

Comment on attachment 249500 [details]
Patch

https://trac.webkit.org/r182039