Bug 143068

Summary:

[Cocoa] RemoteInspectorXPCConnection::deserializeMessage() leaks a NSDictionary under Objective-C GC

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, joepeck, mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Description Andy Estes 2015-03-25 18:58:37 PDT

[Cocoa] RemoteInspectorXPCConnection::deserializeMessage() leaks a NSDictionary under Objective-C GC

Comment 1 Andy Estes 2015-03-25 19:00:55 PDT

Created attachment 249462 [details]
Patch

Comment 2 mitz 2015-03-25 19:34:21 PDT

Comment on attachment 249462 [details]
Patch

Could you have fixed this by adopting the result of _CFXPCCreate… into a RetainPtr and not having to think about GC here?

Comment 3 Andy Estes 2015-03-25 19:52:05 PDT

(In reply to comment #2)
> Comment on attachment 249462 [details]
> Patch
> 
> Could you have fixed this by adopting the result of _CFXPCCreate… into a
> RetainPtr and not having to think about GC here?

Oh, yes! I guess I didn't know / forgot that RetainPtr had an autorelease(). I'll assume that your r+ is still good for doing that instead :) Thanks!

Comment 4 Andy Estes 2015-03-25 20:11:46 PDT

Committed r181992: <http://trac.webkit.org/changeset/181992>