Bug 143062

Summary:

Web Inspector: Add ESLint "Disallow Undeclared Variables" rule and enable ES6 env

Product:

WebKit

Reporter:

Tobias Reiss <tobi+webkit>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none

Description Tobias Reiss 2015-03-25 15:30:10 PDT

As a consequence of further usage of ES6 syntax and a regression that could have been spotted by ESLint we should add the following 2 things:
- es6 environment (allow use of ES6 syntax including class)
- no-undef - disallow use of undeclared variables unless mentioned in a /*global */ block  http://eslint.org/docs/rules/no-undef.html

Comment 1 Radar WebKit Bug Importer 2015-03-25 15:30:32 PDT

<rdar://problem/20300065>

Comment 2 Tobias Reiss 2015-03-25 15:37:03 PDT

Created attachment 249433 [details]
patch

Comment 3 Joseph Pecoraro 2015-03-25 17:00:02 PDT

Comment on attachment 249433 [details]
patch

r=me

Comment 4 WebKit Commit Bot 2015-03-25 17:47:41 PDT

Comment on attachment 249433 [details]
patch

Clearing flags on attachment: 249433

Committed r181987: <http://trac.webkit.org/changeset/181987>

Comment 5 WebKit Commit Bot 2015-03-25 17:47:45 PDT

All reviewed patches have been landed.  Closing bug.