Bug 143035

Summary: Mavericks WK1 still runs JSC tests
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, lforschler, mark.lam, mmirman, msaboff, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix ossy: review+, ossy: commit-queue-

Alexey Proskuryakov
Reported 2015-03-24 20:54:53 PDT
Looks like we missed Mavericks WK1 when disabling JSC tests.
Attachments
proposed fix (2.33 KB, patch)
2015-03-24 20:57 PDT, Alexey Proskuryakov 		ossy: review+
ossy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-03-24 20:57:43 PDT
Created attachment 249384 [details] proposed fix
Csaba Osztrogonác
Comment 2 2015-03-25 00:10:36 PDT
Comment on attachment 249384 [details] proposed fix On Yosemite we have dedicated JSC testers, but on Mavericks we don't, that's why the WK1 bots run the JSC tests too.
Alexey Proskuryakov
Comment 3 2015-03-25 00:18:18 PDT
Yes, but that wasn't the plan. We need layout tests to be fast stronger than we need JSC coverage on Mavericks.
Csaba Osztrogonác
Comment 4 2015-03-25 01:44:47 PDT
Comment on attachment 249384 [details] proposed fix rs=me if Apple don't need JSC test coverage on Mavericks any more.
Csaba Osztrogonác
Comment 5 2015-03-25 01:47:02 PDT
Additionally this change means that Bot watcher's dashboard won't signal any JSC regressions any more. Do we really want it?
Csaba Osztrogonác
Comment 6 2015-03-25 01:50:07 PDT
Comment on attachment 249384 [details] proposed fix Ah, one more thing, please update the unit test too.
Csaba Osztrogonác
Comment 7 2015-03-25 02:33:38 PDT
(In reply to comment #6) > Comment on attachment 249384 [details] > proposed fix > > Ah, one more thing, please update the unit test too. I meant this one: https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py#L367
Alexey Proskuryakov
Comment 8 2015-03-25 10:01:54 PDT
Committed <http://trac.webkit.org/r181962>. As for JSC regressions, Mark Lam is going to look into adding not just the new queue, but also 32-bit and CLOOP LLINT ones to the dashboard.
Csaba Osztrogonác
Comment 9 2015-03-26 04:25:58 PDT
(In reply to comment #8) > Committed <http://trac.webkit.org/r181962>. We need a master restart to apply this change. > As for JSC regressions, Mark Lam is going to look into adding not just the > new queue, but also 32-bit and CLOOP LLINT ones to the dashboard. I missed it, I filed a bug report for it not so long ago - bug143091, feel free to close it as duplicated if you have another one.
Note You need to log in before you can comment on or make changes to this bug.