| Summary: | Mavericks WK1 still runs JSC tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fpizlo, ggaren, lforschler, mark.lam, mmirman, msaboff, ossy, rniwa | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2015-03-24 20:54:53 PDT
Created attachment 249384 [details]
proposed fix
Comment on attachment 249384 [details]
proposed fix
On Yosemite we have dedicated JSC testers, but on Mavericks we don't, that's why the WK1 bots run the JSC tests too.
Yes, but that wasn't the plan. We need layout tests to be fast stronger than we need JSC coverage on Mavericks. Comment on attachment 249384 [details]
proposed fix
rs=me if Apple don't need JSC test coverage on Mavericks any more.
Additionally this change means that Bot watcher's dashboard won't signal any JSC regressions any more. Do we really want it? Comment on attachment 249384 [details]
proposed fix
Ah, one more thing, please update the unit test too.
(In reply to comment #6) > Comment on attachment 249384 [details] > proposed fix > > Ah, one more thing, please update the unit test too. I meant this one: https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py#L367 Committed <http://trac.webkit.org/r181962>. As for JSC regressions, Mark Lam is going to look into adding not just the new queue, but also 32-bit and CLOOP LLINT ones to the dashboard. (In reply to comment #8) > Committed <http://trac.webkit.org/r181962>. We need a master restart to apply this change. > As for JSC regressions, Mark Lam is going to look into adding not just the > new queue, but also 32-bit and CLOOP LLINT ones to the dashboard. I missed it, I filed a bug report for it not so long ago - bug143091, feel free to close it as duplicated if you have another one. |