Summary: | [iOS] Remove unused keyboard code in WKSelectPopover class | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||
Component: | WebKit2 | Assignee: | Enrica Casucci <enrica> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | joepeck | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Enrica Casucci
2015-03-24 14:51:18 PDT
Created attachment 249356 [details]
Patch
Comment on attachment 249356 [details]
Patch
Looks good to me
You can probably remove a bunch of UIKeyboard stuff from UIKitSPI.h, since I would guess this might be the only place it is used.
(In reply to comment #2) > Comment on attachment 249356 [details] > Patch > > Looks good to me > > You can probably remove a bunch of UIKeyboard stuff from UIKitSPI.h, since I > would guess this might be the only place it is used. Unfortunately the keyboard is still widely used in WKContentViewInteraction.mm Thanks for the review! Committed revision 181919. |