Summary: | MediaControls: Use font with fixed number width | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||||
Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Dean Jackson
2015-03-24 14:12:07 PDT
Created attachment 249351 [details]
Patch
WIP - not for review Attachment 249351 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:83: The parameter name "options" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/mac/FontCacheMac.mm:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:619: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 4 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 249352 [details]
Patch
Attachment 249352 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/FontCacheMac.mm:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:619: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 249411 [details]
Patch
Committed r181965: <http://trac.webkit.org/changeset/181965> |