Bug 143018

Summary: MediaControls: Use font with fixed number width
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch eric.carlson: review+

Dean Jackson
Reported 2015-03-24 14:12:07 PDT
MediaControls: Use font with fixed number width
Attachments
Patch (6.39 KB, patch)
2015-03-24 14:13 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (7.66 KB, patch)
2015-03-24 14:20 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (11.05 KB, patch)
2015-03-25 10:29 PDT, Dean Jackson 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2015-03-24 14:12:42 PDT
<rdar://problem/20245415>
Dean Jackson
Comment 2 2015-03-24 14:13:30 PDT
Created attachment 249351 [details] Patch
Dean Jackson
Comment 3 2015-03-24 14:13:44 PDT
WIP - not for review
WebKit Commit Bot
Comment 4 2015-03-24 14:15:36 PDT
Attachment 249351 [details] did not pass style-queue: ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:83: The parameter name "options" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/graphics/mac/FontCacheMac.mm:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:619: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 4 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dean Jackson
Comment 5 2015-03-24 14:20:10 PDT
Created attachment 249352 [details] Patch
WebKit Commit Bot
Comment 6 2015-03-24 14:22:46 PDT
Attachment 249352 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/FontCacheMac.mm:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:619: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dean Jackson
Comment 7 2015-03-25 10:29:26 PDT
Created attachment 249411 [details] Patch
Dean Jackson
Comment 8 2015-03-25 10:44:47 PDT
Committed r181965: <http://trac.webkit.org/changeset/181965>
Note You need to log in before you can comment on or make changes to this bug.