Bug 143016

Summary: Fix designated initializer violations
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Anders Carlsson 2015-03-24 13:30:16 PDT 
Fix designated initializer violations
Comment 1 Anders Carlsson 2015-03-24 13:37:27 PDT 
Created attachment 249346 [details]
Patch
Comment 2 mitz 2015-03-24 13:58:49 PDT 
Comment on attachment 249346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249346&action=review

> Source/WebCore/bindings/objc/DOMObject.mm:-48
> -    [self release];

You shouldn’t remove this.
Comment 3 Anders Carlsson 2015-03-24 14:14:29 PDT 
(In reply to comment #2)
> Comment on attachment 249346 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249346&action=review
> 
> > Source/WebCore/bindings/objc/DOMObject.mm:-48
> > -    [self release];
> 
> You shouldn’t remove this.

This has always been dead code, and once you raise an exception all memory management goes out the door anyway. This just follows the established pattern that other frameworks use (Foundation for example).
Comment 4 Anders Carlsson 2015-03-24 14:18:13 PDT 
Committed r181906: <http://trac.webkit.org/changeset/181906>