Bug 143016 - Fix designated initializer violations
Summary: Fix designated initializer violations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-24 13:30 PDT by Anders Carlsson
Modified: 2015-03-24 14:18 PDT (History)
0 users

See Also:

Attachments
Patch (8.07 KB, patch)
2015-03-24 13:37 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-03-24 13:30:16 PDT 
Fix designated initializer violations
Comment 1 Anders Carlsson 2015-03-24 13:37:27 PDT 
Created attachment 249346 [details]
Patch
Comment 2 mitz 2015-03-24 13:58:49 PDT 
Comment on attachment 249346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249346&action=review

> Source/WebCore/bindings/objc/DOMObject.mm:-48
> -    [self release];

You shouldn’t remove this.
Comment 3 Anders Carlsson 2015-03-24 14:14:29 PDT 
(In reply to comment #2)
> Comment on attachment 249346 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249346&action=review
> 
> > Source/WebCore/bindings/objc/DOMObject.mm:-48
> > -    [self release];
> 
> You shouldn’t remove this.

This has always been dead code, and once you raise an exception all memory management goes out the door anyway. This just follows the established pattern that other frameworks use (Foundation for example).
Comment 4 Anders Carlsson 2015-03-24 14:18:13 PDT 
Committed r181906: <http://trac.webkit.org/changeset/181906>