Bug 143008

Summary: Improve the offsetWidth/Height layout optimization
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, esprehn+autocc, kangil.han, mark.lam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 143034    
Bug Blocks:    
Attachments:
Description Flags
Patch
dino: review+
Patch zalan: review+

Dave Hyatt
Reported 2015-03-24 10:02:34 PDT
This patch covers some improvements to the offsetWidth/Height computation for avoiding layout.
Attachments
Patch (7.93 KB, patch)
2015-03-24 10:04 PDT, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
Patch (8.49 KB, patch)
2015-03-25 12:05 PDT, Dave Hyatt 		zalan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2015-03-24 10:04:18 PDT
Created attachment 249333 [details] Patch
WebKit Commit Bot
Comment 2 2015-03-24 10:05:42 PDT
Attachment 249333 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2015-03-24 12:14:07 PDT
Fixed in r181898.
Alexey Proskuryakov
Comment 4 2015-03-24 13:26:38 PDT
This broke fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html on WK1, not sure why EWS didn't notice. Maybe it fails when run with other tests, but succeeeds alone? https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fregions%2Fauto-size%2Fautoheight-two-pass-layout-complex-002.html
Mark Lam
Comment 5 2015-03-24 19:20:33 PDT
(In reply to comment #4) > This broke > fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html on WK1, > not sure why EWS didn't notice. Maybe it fails when run with other tests, > but succeeeds alone? > > https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=fast%2Fregions%2Fauto-size%2Fautoheight-two-pass- > layout-complex-002.html r181909: <http://trac.webkit.org/changeset/181909> made it better for WK2 on Yosemite, but the test is still failing on WK1 Yosemite, and on Mavericks bots.
Alexey Proskuryakov
Comment 6 2015-03-24 20:47:29 PDT
As it still fails and Dave is not around, rolling out.
WebKit Commit Bot
Comment 7 2015-03-24 20:49:07 PDT
Re-opened since this is blocked by bug 143034
Dave Hyatt
Comment 8 2015-03-25 12:05:17 PDT
Created attachment 249421 [details] Patch
Dave Hyatt
Comment 9 2015-03-26 12:10:15 PDT
Fixed in r182022.
Note You need to log in before you can comment on or make changes to this bug.