| Summary: | Improve the offsetWidth/Height layout optimization | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, esprehn+autocc, kangil.han, mark.lam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 143034 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Dave Hyatt
2015-03-24 10:02:34 PDT
Created attachment 249333 [details]
Patch
Attachment 249333 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
This broke fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html on WK1, not sure why EWS didn't notice. Maybe it fails when run with other tests, but succeeeds alone? https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fregions%2Fauto-size%2Fautoheight-two-pass-layout-complex-002.html (In reply to comment #4) > This broke > fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html on WK1, > not sure why EWS didn't notice. Maybe it fails when run with other tests, > but succeeeds alone? > > https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=fast%2Fregions%2Fauto-size%2Fautoheight-two-pass- > layout-complex-002.html r181909: <http://trac.webkit.org/changeset/181909> made it better for WK2 on Yosemite, but the test is still failing on WK1 Yosemite, and on Mavericks bots. As it still fails and Dave is not around, rolling out. Re-opened since this is blocked by bug 143034 Created attachment 249421 [details]
Patch
|