Bug 143005

Summary: Add back previously broken assert from bug 141869
Product: WebKit Reporter: Saam Barati <sbarati>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
msaboff: review+, commit-queue: commit-queue-
patch
none
patch none

Description Saam Barati 2015-03-24 08:44:57 PDT
Assert broke debug builds because it
referenced an undeclared function parameter. 
But, if the parameter is declared, the assert
is valid.
Comment 1 Saam Barati 2015-03-24 18:14:15 PDT
Created attachment 249371 [details]
patch
Comment 2 Michael Saboff 2015-03-24 18:15:29 PDT
Comment on attachment 249371 [details]
patch

Looks like it will build!
r=me
Comment 3 WebKit Commit Bot 2015-03-24 19:02:07 PDT
Comment on attachment 249371 [details]
patch

Rejecting attachment 249371 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
mes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/TypeProfilerLog.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/ExceptionHelpers.o runtime/ExceptionHelpers.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.appspot.com/results/5717390864154624
Comment 4 Saam Barati 2015-03-24 19:22:49 PDT
(In reply to comment #3)
> Comment on attachment 249371 [details]
> patch
> 
> Rejecting attachment 249371 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch',
> '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build',
> '--no-clean', '--no-update', '--build-style=release', '--port=mac']"
> exit_code: 2 cwd: /Volumes/Data/EWS/WebKit
> 
> Last 500 characters of output:
> mes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp -o
> /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/
> JavaScriptCore.build/Objects-normal/x86_64/TypeProfilerLog.o
> 
> ** BUILD FAILED **
> 
> 
> The following build commands failed:
> 	CompileC
> /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/
> JavaScriptCore.build/Objects-normal/x86_64/ExceptionHelpers.o
> runtime/ExceptionHelpers.cpp normal x86_64 c++
> com.apple.compilers.llvm.clang.1_0.compiler
> (1 failure)
> 
> Full output: http://webkit-queues.appspot.com/results/5717390864154624

This seems weird. Builds fine on my machine. I'll update locally
and see if it breaks on my clean build.
Comment 5 Saam Barati 2015-03-27 09:34:43 PDT
Created attachment 249573 [details]
patch

lets give this another go.
If bots are okay with it, I will cq+
Comment 6 Saam Barati 2015-03-27 12:51:49 PDT
Created attachment 249599 [details]
patch

one more time
should be using ASSERT_UNUSED
Comment 7 WebKit Commit Bot 2015-03-27 14:57:20 PDT
Comment on attachment 249599 [details]
patch

Clearing flags on attachment: 249599

Committed r182083: <http://trac.webkit.org/changeset/182083>
Comment 8 WebKit Commit Bot 2015-03-27 14:57:25 PDT
All reviewed patches have been landed.  Closing bug.