Bug 143003 – [GTK] Gardening 24th March

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Marcos Chavarría Teijeiro (irc: chavaone)]

Unreviewed GTK+ Gardening test

[Marcos Chavarría Teijeiro (irc: chavaone)]

Created attachment 249325 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 249325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249325&action=review

> LayoutTests/platform/gtk/TestExpectations:2369
> +#This tests are passing on GTK+ but they do not in the Apple ports

Please, put a space after the #

> LayoutTests/platform/gtk/TestExpectations:2372
> +  transitions/svg-text-shadow-transition.html [ Pass ]

Here there are two leading spaces that souldn't be.

[Marcos Chavarría Teijeiro (irc: chavaone)]

Created attachment 249329 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 249329 [details]
Patch

thanks

[WebKit Commit Bot]

Comment on attachment 249329 [details]
Patch

Rejecting attachment 249329 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 249329, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 LayoutTests/platform/gtk/css3/selectors3/xhtml/css3-modsel-15c-expected.txt
patching file LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-15c-expected.txt
patching file LayoutTests/platform/gtk/plugins/npruntime/object-from-destroyed-plugin-expected.txt
patching file LayoutTests/platform/gtk/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4836020088471552

[Carlos Alberto Lopez Perez]

Seems that the patch failed to apply on trunk:

Last 500 characters of output:
fset -1 lines).
1 out of 6 hunks FAILED -- saving rejects to file LayoutTests/platform/gtk/TestExpectations.rej

Can you rebase it and upload it again?

[Marcos Chavarría Teijeiro (irc: chavaone)]

Created attachment 249392 [details]
Patch

[Marcos Chavarría Teijeiro (irc: chavaone)]

(In reply to comment #6)
> Seems that the patch failed to apply on trunk:
> 
> Last 500 characters of output:
> fset -1 lines).
> 1 out of 6 hunks FAILED -- saving rejects to file
> LayoutTests/platform/gtk/TestExpectations.rej
> 
> Can you rebase it and upload it again?

done!

[Carlos Alberto Lopez Perez]

Comment on attachment 249392 [details]
Patch

let's retry it

[WebKit Commit Bot]

Comment on attachment 249392 [details]
Patch

Clearing flags on attachment: 249392

Committed r181953: <http://trac.webkit.org/changeset/181953>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.